Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce complexity by removing rc::Ref #5238

Closed
wants to merge 1 commit into from
Closed

Conversation

rbran
Copy link
Contributor

@rbran rbran commented Apr 5, 2024

Types that use rc::Ref only exists as References, so it makes sense to replace all occurrences of Ref<T> with T and move the Ref::inc_ref and Ref::dec_ref implementations to Clone and Drop.

@ElykDeer
Copy link
Member

ElykDeer commented Apr 9, 2024

This is very interesting. I'll have to talk about this internally with the team to see if we want this. Thank you for the initial effort!

@ElykDeer ElykDeer self-assigned this Apr 9, 2024
@ElykDeer ElykDeer closed this Apr 16, 2024
@rbran rbran mentioned this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants