Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SharedCache] Remove unnecessary lock in SharedCache destructor #6194

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

[SharedCache] Remove unnecessary lock in SharedCache destructor #6194

wants to merge 1 commit into from

Commits on Nov 25, 2024

  1. [SharedCache] Remove unnecessary lock in SharedCache destructor 

    From what I can tell the lock being taken in `SharedCache::~SharedCache` was purely for the decrement of `sharedCacheReferences`, however its an atomic so a lock isn't necessary. The lock being taken is extremely contentious and therefore often slow to be acquired. This resulted in a surprising amount of execution time spent in the `SharedCache` destructor. Nothing hugely significant but a quick and easy win to remove this single line of code.
    WeiN76LQh authored and WeiN76LQh committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    ec5a0e1 View commit details
    Browse the repository at this point in the history