[SharedCache] Inline CFStrings
#6302
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Basically just copied from the [workflow objc plugin](https://github.com/Vector35/workflow_objc) with [PR Vector35#67](Vector35/workflow_objc#67) applied. Ideally this would not be a copy and these 2 codebases would share the code but its unclear if Vector35 would want to import the Objective-C workflow plugin into the BN API repo and what that would look like. So this is an intermediary solution to get `CFString` inlining working in DSC.
|
While I'd eventually like to add functionality used in workflow-objc here, we're looking to use a different approach for CFString inlining and other objc representations. (see pseudo-language representation stuff added in latest major release). The CFString inlining approach used in the old workflow was very hacky and it's actually disabled currently due to causing a lot of problems with IL output since we were misusing intrinsic pretty badly. I think the current variable naming approach should be sufficient for now. Thank you for this PR though! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically just copied from the workflow objc plugin with PR #67 applied.
Ideally this would not be a copy and these 2 codebases would share the code but its unclear if Vector35 would want to import the Objective-C workflow plugin into the BN API repo and what that would look like. So this is an intermediary solution to get
CFStringinlining working in DSC.