Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing hs_version.h header (closes #198) #199

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

gliwka
Copy link

@gliwka gliwka commented Nov 20, 2023

This PR adds the missing hs_version.h (issue #198) to the files to be installed

@gliwka gliwka force-pushed the fix-missing-hs-version-header branch from 65a5059 to 42a4b7f Compare November 20, 2023 17:42
@markos
Copy link

markos commented Nov 20, 2023

Would you mind sending this PR against develop branch? It doesn't matter much in this particular case as they are exactly the same.

@gliwka gliwka changed the base branch from master to develop November 20, 2023 19:40
@gliwka
Copy link
Author

gliwka commented Nov 20, 2023

Will do, just need to rebase 👍

@gliwka gliwka force-pushed the fix-missing-hs-version-header branch from 42a4b7f to 83b08b1 Compare November 20, 2023 19:52
@gliwka gliwka force-pushed the fix-missing-hs-version-header branch from 83b08b1 to 343e523 Compare November 20, 2023 19:52
@gliwka
Copy link
Author

gliwka commented Nov 20, 2023

@markos Done :-)

CMakeLists.txt Show resolved Hide resolved
Copy link

@markos markos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Approved

@markos markos merged commit c3a6bb3 into VectorCamp:develop Nov 21, 2023
@markos markos mentioned this pull request Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants