Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Make hidden _tokenURI direct return use exact padding #130

Merged
merged 1 commit into from
Apr 14, 2024

Conversation

Vectorized
Copy link
Owner

@Vectorized Vectorized commented Apr 14, 2024

Description

♻️

Shouldn't be an issue, cuz most won't call tokenURI directly on the DN404, but instead on DN404Mirror. And this affects abi decode in older JS libraries.

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Ran forge fmt?
  • Ran forge snapshot?
  • Ran forge test?

Pull requests with an incomplete checklist will be thrown out.

@Vectorized Vectorized merged commit 6234d42 into main Apr 14, 2024
9 checks passed
@Vectorized Vectorized deleted the padded-return branch April 14, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant