✨ Adds a means to bypass fixed addresses for LibMulticaller #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I find it a bit odd that the gas snapshot appears to be lower when i abstracted behind multiple internal calls. I do not understand why that is happening. |
3commascapital
force-pushed
the
adds-address-rename
branch
from
3dd7b38
to
12acdd8
Compare
3commascapital
force-pushed
the
adds-address-rename
branch
from
98e4d76
to
7073bfc
Compare
Vectorized
reviewed
Apr 8, 2024
| } | ||
| } | ||
|
|
||
| function getAt(address loc) internal view returns (address result) { |
There was a problem hiding this comment.
I'll rename to at(address a), resolve(address a) respectively, for mouthfeel.
Vectorized
changed the title
Vectorized
added a commit
that referenced
this pull request
Apr 8, 2024
* ✨ Adds a means to bypass fixed addresses for LibMulticaller (#34) Co-authored-by: 3commascapital <3commascapital@github.com> * Tidy --------- Co-authored-by: 3commascapital <90629478+3commascapital@users.noreply.github.com> Co-authored-by: 3commascapital <3commascapital@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made in your pull request here.
Checklist
Ensure you completed all of the steps below before submitting your pull request:
forge fmt?forge snapshot?forge test?Pull requests with an incomplete checklist will be thrown out.
new feature ✨