Feature 301: AWS S3 파일 업로드 기능 구현 #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. 이미지는 필수 파라미터가 아님 2. 의존성 주입을 위한 final 키워드 누락
O-Wensu
reviewed
Jul 30, 2024
Comment on lines
+3
to
+7
| public enum AwsS3Folders { | ||
| COMMUNITY("community/"), | ||
| LIFE_CHECK("lifecheck/"), | ||
| PROFILE("profile/"), | ||
| RECIPE("recipe/"); |
There was a problem hiding this comment.
enum으로 파일 경로를 관리하면 직접 작성하지 않아도 돼서 가독성과 편의성이 좋을 것 같아요. 좋은 생각이네요!
Comment on lines
+72
to
+74
| String fileExtension = | ||
| originalFilename.substring(originalFilename.lastIndexOf(".") + 1).toLowerCase(); | ||
| List<String> allowedExtensions = Arrays.asList("jpg", "png", "gif", "jpeg"); |
There was a problem hiding this comment.
구체적인 파일 확장자를 고려한 점이 좋아요!
그런데 gif 확장자는 움직이는 이미지인데, 허용 범위에 포함되는지 궁금합니다!
There was a problem hiding this comment.
일단 이미지 확장자는 다 넣었는데, 그건 논의해봐야 할 것 같네용
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이슈 번호 (#301)
요약
RequestPart사용)Swaager에서
RequestPart를 지원하지 않음RequestPart가 아닌 json 으로 처리됨