Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mac: Set minimum OS requirement in plist #26

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Vilagamer999
Copy link

Change plist requirements to allow installing on macOS Catalina and later

Allows installing on macOS Catalina and later
@Vendicated
Copy link
Member

that's a bit of a specific version, wouldn't just 10 work? Also have u tried compiling & building the app folder and seeing if it works?

@Vilagamer999
Copy link
Author

that's a bit of a specific version, wouldn't just 10 work?

True that's smarter, I just set it to the latest available version...

Also have u tried compiling & building the app folder and seeing if it works?

Doing that now

@Imzxhir
Copy link

Imzxhir commented Mar 20, 2023

Would MacOS Version 10.13 work? I know not many people use that version nowadays but still, it can open up the installer to a wide variety of users that can't upgrade.

@Vendicated
Copy link
Member

Try it and see

@Imzxhir
Copy link

Imzxhir commented Mar 20, 2023

I changed it to 10.13 but it didn't work. The dialog kept saying it needed 12.0 even though I set it to 10.13

@Vendicated
Copy link
Member

As I said I don't have a Mac, nor do I really care about supporting Mac, so I won't be of much help, sorry.

This might be helpful https://bignerdranch.com/blog/requiring-a-minimum-version-of-os-x-for-your-application/

@Vendicated Vendicated changed the title Update Info.plist mac: Set minimum OS requirement in plist Mar 21, 2023
@Vendicated Vendicated added enhancement New feature or request help wanted Extra attention is needed labels Mar 21, 2023
@Vilagamer999
Copy link
Author

Would MacOS Version 10.13 work? I know not many people use that version nowadays but still, it can open up the installer to a wide variety of users that can't upgrade.

Theoretically it should work on all the macOS versions that support x64 applications (and M1/2 through rosetta)

I tried building the app directly on macOS but it was not happy, I'll try build it on windows tomorrow and test it.

@forever-and-a-day
Copy link

Tried building this on Linux to run on a computer with MacOS Big Sur (11.x) - build was fine, but unfortunately wouldn't run. The target computer still refused to run it, saying it only supported MacOS 12 (Monterey) even with the changed plist file.

@Vendicated Vendicated marked this pull request as draft April 28, 2023 02:17
@nyathea
Copy link

nyathea commented May 16, 2023

Workaround for macOS 11 Big Sur (if people havent found it out yet):
Right click on VencordInstaller.app and press "Show Package Contents" go to Package > Contents and click on the VencordInstaller exucutable. it will open up a terminal window and the Installer will work without issues.

@Imzxhir
Copy link

Imzxhir commented Oct 2, 2023

Theoretically it should work on all the macOS versions that support x64 applications (and M1/2 through rosetta)

I tried building the app directly on macOS but it was not happy, I'll try build it on windows tomorrow and test it.

I tried to build the installer, and it ran fine. But, when I tried to run the Vencord.app, it resulted with this:

image

I think it is a problem with the VencordInstaller executable and that it sets the minimum requirement to 12.0 for some reason.

@Imzxhir
Copy link

Imzxhir commented Oct 2, 2023

Update: I was right. If I build manually with the same flags as the GitHub Workflow and compile it to a .app, I get a build / .app file that is compatible with 10.13.6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants