feat: Add a toggle in the settings for video hardware acceleration #1117
+12
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
does voice & video > hardware acceleration not already do this..? |
|
ok just tested. seemingly does nothing.. I guess discord just didnt desktop gate that switch 💀.. Instead of adding a new switch to vesktop settings you might want to get the state of that switch and go from there. (look at the streamer mode patch for a similar thingy) |
|
Oh, that does seem like a better way to do it, I'll take a look. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a toggle for video hardware acceleration in the Vesktop Settings while keeping overall hardware acceleration turned on, since video hardware acceleration may cause screen-share issues in some systems.
Would add a workaround to issues like #1107, #1004, #851 and #797