add linux audio screensharing

[Vendicated]

Adds audio screenshare on linux via pipewire

Allows you to choose to share either your entire system audio (without Discord), or a specific application

TODO

• kill virtmic once stream is stopped

Needs testing

• Behaves correctly on pulseaudio. That is: does not crash; displays "failed to retrieve audio sources"
• works on fedora
• works on ubuntu
• works on steamos
• works for sharing audio of individual apps
• works for sharing system audio without including discord itself

resolves #117

[uku3lig]

Doesn't work on wayland, the XDG portal window picker opens just fine and allows to select a window but then the vencord picker is empty:

In addition, pipewire seems to error after selecting something in the portal picker: 'loop->recurse > 0' failed at ../pipewire/src/pipewire/thread-loop.c:426 pw_thread_loop_wait()

Also after canceling clicking on the Go Live button again doesn't do anything, without anything being output in the logs and when closed exists with a SIGSEGV.

(Tested both on Hyprland 0.30.0 and GNOME 44.4)

[Vendicated]

yes

[catgirlcataclysm]

Doesn't work on wayland, the XDG portal window picker opens just fine and allows to select a window but then the vencord picker is empty:

In addition, pipewire seems to error after selecting something in the portal picker: 'loop->recurse > 0' failed at ../pipewire/src/pipewire/thread-loop.c:426 pw_thread_loop_wait()

Also after canceling clicking on the Go Live button again doesn't do anything, without anything being output in the logs and when closed exists with a SIGSEGV.

(Tested both on Hyprland 0.30.0 and GNOME 44.4)

Try my fork, wayland-fixes branch.
Most of those issues should be resolved

[uku3lig]

Try my fork, wayland-fixes branch. Most of those issues should be resolved

this seems to be working fine, except for one little issue: electron 26 turns the app into a white screen a few seconds after launch, as described in #125. works fine on electron 25.8.2

[maltejur]

Instead of the virtmic binary you could try to use https://github.com/kakxem/node-pipewire, that may be a bit cleaner than bundling a prebuilt binary.

[Vendicated]

these issues should now all be fixed (including the electron 26 whitescreen)

---

Instead of the virtmic binary you could try to use kakxem/node-pipewire, that may be a bit cleaner than bundling a prebuilt binary.

Curve is helping us turn it into a native addon instead. thanks for the idea though!

[maltejur]

Curve is helping us turn it into a native addon instead. thanks for the idea though!

Ah yeah that also sounds like a good idea.

I tested the code on KDE Wayland btw and it works great for me, besides the thing with the screen sharing portal popping up multiple times. That is a interesting bug, because it also happens in Chrome directly (when just trying to share your screen on a random website), but funnily enough not in qtwebengine (also based on chromium).

[Vendicated]

besides the thing with the screen sharing portal popping up multiple times

yeah, it's sadly still an issue even after all these fixes. The first time it requests is normal, and it calls our electron registered handler. then right before it starts streaming, it asks again, this time without triggering the electron handler

on a random website

so it happens on any website, not just discord?

[maltejur]

so it happens on any website, not just discord?

Yup, on https://webrtc.github.io/samples/src/content/getusermedia/getdisplaymedia too for example. In Chrome it shows the portal, then the Chrome dialog, then the portal again, then the stream starts. In Firefox it works as expected, with it first showing the Firefox dialog, then the portal, and then starting the stream.

[Vendicated]

what chromium version are you using? the site you linked works correctly for me on Version 117.0.5938.149 (Official Build, ungoogled-chromium) (64-bit)

[maltejur]

Version 118.0.5993.70 (Official Build) Arch Linux (64-bit)

Interesting, maybe this is a recent bug.

[maltejur]

Hm, no, the version ain't it. If I try the version you linked I get the same behaviour. My description of what is happening may have been a bit bad. At first the chrome dialog opens, when you try to select the "Window" tab, you get the first portal, and when you press "Share" you get the second portal.

[Vendicated]

i just installed chrome and it works fine for me on Version 118.0.5993.70 (Official Build) (64-bit) (fedora)

here's a recording, in case i'm misunderstanding

Screencast.from.2023-10-12.00-17-14.webm

[Vendicated]

maybe it's an issue with pipewire itself or whichever DE/WM you use?
Here's mine:

gnome 44.5

pipewire
Compiled with libpipewire 0.3.81
Linked with libpipewire 0.3.81

or - considering it happens for me in electron too, maybe related to some chromium build flag?

[maltejur]

Pipewire is same for me, but I am using KDE

KDE Plasma Version 5.27.8
KDE Frameworks Version 5.110.0
Qt Version 5.15.11

pipewire
Compiled with libpipewire 0.3.81
Linked with libpipewire 0.3.81

I also tried the Chrome Flatpak, same behaviour. So I suspect this is more of a KDE/Gnome difference.

I'll try to attach a screen recording, but that is suprisingly difficult to create on Wayland :D

[maltejur]

2023-10-12.00-31-24.mp4

[Vendicated]

i just installed kde and can't repro

webrtc.mp4

[Vendicated]

This pr is now very close to being done and you no longer need to build virtmic/venmic yourself

i have added a few things that still need testing to the description at the top. if you are able to test any of them, please do and report your results

[D3SOX]

It works for fine for me

pls merge

[D3SOX]

I just noticed this always exists after the audio selection input was shown once. Can't it be killed when no stream is running?

[Curve]

I just noticed this always exists after the audio selection input was shown once. Can't it be killed when no stream is running?

Recreating the virtual device would be absolutely unnecessary imho but could be added

[uku3lig]

it seems that applications using pipewire-alsa are not detected (or at least don't show up in the audio selection menu), see attached screenshot (tested on pipewire 0.3.82, the two apps shown are osu-lazer launched with SDL_VIDEODRIVER=wayland and uku3lig/csf-reader)

edit: i dm'ed curve on discord about this issue

[Curve]

~snip

@uku3lig

Currently only applications that contain certain props are shown (namely application.process.id, application.process.binary and node.name).

Could you please send in the output of pw-dump while OSU is playing audio?

We might need to give the client control over which props he requires to be included (maybe an option similar to "Show all processes")

[Curve]

~snip

@uku3lig

Currently only applications that contain certain props are shown (namely application.process.id, application.process.binary and node.name).

Could you please send in the output of pw-dump while OSU is playing audio?

We might need to give the client control over which props he requires to be included (maybe an option similar to "Show all processes")

The output is probably going to be pretty big or may contain some personal info (username, and so on)

If you want to you can also DM me the output on discord: @curve.cpp

[wearrrrr]

Just tested and it works flawlessly 👍, both app and entire system audio work. :D

[milenakos]

works good on ubuntu

[Vendicated]

hi @uku3lig, could you try again now and see if your issue is fixed?

[uku3lig]

works flawlessly, thank you very much!

[afrozenpeach]

Vencord claims it can't retrieve my sound sources and says to use pipewire, but I'm definitely using pipewire. Here's a pw-dump output from my system.

pwdump.txt

[Vendicated]

probably related to using older glibc++. will be fixed once we publish our flatpak soon (and if you use that). Or you can update it manually

please don't necro closed prs in the future, instead make a new issue!

[leo60228]

This might be a fairly niche usecase, but would it be possible to have a way to select a real audio input for screensharing? My usecase for this is streaming from a game console where my capture solution only handles video, so I just connect the console's audio output to my motherboard's line in jack.

[Curve]

This might be a fairly niche usecase, but would it be possible to have a way to select a real audio input for screensharing? My usecase for this is streaming from a game console where my capture solution only handles video, so I just connect the console's audio output to my motherboard's line in jack.

Venmic allows this, it would have to be utilized by vencord but that should be fairly easy

[Vendicated]