Fix : VM class for AppImage has broken Dekstop integrations #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, after installing Vencord Via AppImage, I've noticed that if I use a desktop integration tool, my VM doesn't put them in the same icon (so VMClass)
In the build section of the package.json I've added StartupVMClass as it's what's expected for most desktop environment (I didn't removed VMClass as I don't really know if its useful or not for other things.)
Also it's weird that there are two Icons shipped. like if the app image one has it's own bundled and the app another one. (It doesn't bother at all, but maybe it would be nice to choose what logo is the Icon)
But it's always cleaner to have it in the same VMClass for any desktop.