-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option for custom startup animations #355
base: main
Are you sure you want to change the base?
Conversation
I wouldn't recommend merging this at the moment, since it's currently broken under Windows. It's running into some issue reading the image file, and I haven't been able to do any testing. |
Is anyone else able to test this on Windows? The person I had asked to test it before didn't rebuild the app properly. They rebuilt it today with the latest changes, and it's working now. |
Works for me 👍 definitely needed! |
is there anything blocking the merging of this that I could help with? If you guys need another tester for this on Windows in addition to the two people above, I could try it out. |
Now that all the merge conflicts are fixed (thanks to @sz6084), do you have any suggestions on how this PR can be improved? Considering the demand for this feature, hopefully we can get this merged as soon as possible. |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
You can technically build ading2210's repository from source by following the same steps as Vencord's repository but changing the URL for cloning to match: git clone https://github.com/ading2210/Vesktop
cd Vesktop
# Install Dependencies
pnpm i
# Either run it without packaging
pnpm start
# Or package
pnpm package
# Or only build the pacman target
pnpm package --linux pacman
# Or package to a directory only
pnpm package:dir |
The ability to select multiple and have them picked at random would be nice as well. |
This comment was marked as spam.
This comment was marked as spam.
ppl want more features in the pr for some reason :/ |
This comment was marked as spam.
This comment was marked as spam.
using ading2210's repo works for the intended feature, (I can set custom splash screen) however my only issue with this repo is the go live screen doesnt let me select an audio source from a single application like the master branch does, I just get "Entire System" or "none", my understanding is that the custom splash feature is going to be merged with master branch, but i just wanted to see if anyone had a solution to this problem |
I added a preview of the splash image to the Vesktop settings menu. This is an important requirement for loading the animation from the Vesktop cache, since displaying only the file path won't be possible with that approach. I do eventually plan to implement all of the suggestions in #667, such as adding the ability to choose multiple images that are selected randomly and adding a toggle to turn off the splash screen entirely. |
This comment was marked as spam.
This comment was marked as spam.
Seems youre not correctly creating the splash directory |
@Covkie That error is fixed in the latest commit. It was happening because Vesktop was unconditionally trying to delete and remake the splash directory, even if it didn't exist before. Obviously this would have caused an error when it tried to remove a nonexistent directory, but it didn't happen in my previous testing because that directory was already there. |
Can't wait to get rid of the furry splash:) |
so when |
Do you know if the way this has been implemented will support APNGs? They tend to be of better quality and of smaller filesize. Perhaps even AVIF or WebP. 😁 |
@MMachado05 An |
I've gone ahead and done some testing with this PR on linux. From what I can see, everything seems to work perfectly on my end. Imo, this is ready for merging but I'm not a maintainer soooo |
Has this been Flatpak tested? |
Based on feedback from #354, I've implemented a way to set a custom image on the splash window. The file is loaded from the user's filesystem, so no copyrighted assets are used.
vesktop_custom_splash-2024-01-22_23.45.06.mp4
This fixes issue #352 completely.