Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add splash window theming #52

Merged
merged 2 commits into from
Oct 14, 2023
Merged

Conversation

ryanccn
Copy link
Contributor

@ryanccn ryanccn commented Jul 9, 2023

Obtains the --text-normal and --background-primary CSS variables from the CSSOM after document load, saves them in Vencord Desktop settings, and overrides --fg and --bg in the splash screen with these values if they exist.

@ryanccn
Copy link
Contributor Author

ryanccn commented Jul 9, 2023

Huh, types are fine in VS Code

src/main/mainWindow.ts Outdated Show resolved Hide resolved
@Vendicated
Copy link
Member

Vendicated commented Jul 14, 2023

Huh, types are fine in VS Code

That likely means our typescript dependency is outdated

Edit: Updated & types fixed

src/main/splash.ts Outdated Show resolved Hide resolved
src/renderer/themedSplash.ts Outdated Show resolved Hide resolved
@Vendicated
Copy link
Member

hmm, it seems like this doesn't work with Discord's nitro themes. It would be really nice if they were also supported

@Vendicated
Copy link
Member

fg-semi-trans should also be changed so the border has the proper colour

@ryanccn ryanccn requested a review from Vendicated July 14, 2023 11:41
src/main/splash.ts Outdated Show resolved Hide resolved
@ryanccn ryanccn requested a review from Vendicated July 15, 2023 11:19
package.json Outdated Show resolved Hide resolved
@Vendicated
Copy link
Member

hmm i tested (with clearvision) and it doesn't seem to do anything for me

@ryanccn ryanccn force-pushed the themed-splash branch 3 times, most recently from 13da9e9 to 6f1fad0 Compare August 4, 2023 12:47
@ryanccn ryanccn force-pushed the themed-splash branch 3 times, most recently from 3305e37 to 54c9e98 Compare August 16, 2023 00:59
@ryanccn ryanccn force-pushed the themed-splash branch 2 times, most recently from 6656593 to 1c6d32c Compare September 1, 2023 12:50
src/main/utils/color.ts Outdated Show resolved Hide resolved
@Vendicated
Copy link
Member

cool, thanks!

@Vendicated Vendicated closed this Oct 14, 2023
@Vendicated
Copy link
Member

oh no..........

@Vendicated Vendicated reopened this Oct 14, 2023
@Vendicated Vendicated enabled auto-merge (squash) October 14, 2023 03:04
@Vendicated Vendicated merged commit 841cdcf into Vencord:main Oct 14, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants