MHC-491: fix PostNL order data save, when ac_information exist in req… #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tjitse-E
approved these changes
Apr 19, 2024
Tjitse-E
deleted the
bugfix/MHC-491-fix_postnl_order_data_save_with_ac_information
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix PostNL order data save, when ac_information exist in request params
Problem description:
in some cases on checkout (for example when selecting Norway country) when saving PostNL order data there are
ac_informationdata set in request params. This data is array, but was set via just $order->setData() as string value.Which throws an error during saving it to database.
So in case of
ac_informationnow it is using$postnlOrder->setAcInformation($value)method, which is serializing value before setting it.