Skip to content
This repository has been archived by the owner on Apr 11, 2024. It is now read-only.

Use POST instead of GET redirect to checkout #5

Open
pkarw opened this issue Mar 14, 2019 · 1 comment
Open

Use POST instead of GET redirect to checkout #5

pkarw opened this issue Mar 14, 2019 · 1 comment
Labels
enhancement New feature or request

Comments

@pkarw
Copy link

pkarw commented Mar 14, 2019

Currently, VS is syncing the shopping cart with Magento in a sequence of pull/update calls. It's possible, especially when Magento2 API responds slowly - that some of these requests were not executed before User gets redirected to the checkout. In that case, cart might get out of sync.

It would be safer to create the full order object and pass it via POST to Magento2. In that case, the Magento2 module should do the sync of the passed order object with the quote.

Something similar to: https://github.com/DivanteLtd/vue-storefront-api/blob/d8775e903c8f345e86abbad33ff9ac2cef070755/src/platform/magento2/o2m.js#L79

By doing so, we're 100% sure that the magento2 cart is in full sync with VS

@Tjitse-E
Copy link
Member

Good idea!

@Tjitse-E Tjitse-E added the enhancement New feature or request label Mar 19, 2019
glevhen added a commit to glevhen/vsf-external-checkout that referenced this issue Jun 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants