feat(themes): Online Themes CSS Override #3017
Open
+247
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuna0x0
force-pushed
the
online-theme-override
branch
5 times, most recently
from
241836f
to
b59f39e
Compare
|
I think it'd be better as a modal rather than an inline, inline (at least, from my experience) has always been a lot more messy and hard to use |
yuna0x0
force-pushed
the
online-theme-override
branch
from
b59f39e
to
7152417
Compare
I agree with this. Change to modal component. 
|
yuna0x0
force-pushed
the
online-theme-override
branch
from
7152417
to
197a970
Compare
yuna0x0
force-pushed
the
online-theme-override
branch
from
197a970
to
40bc76b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1466.
This PR implemented an online theme CSS override feature, which allows user to configure their online theme using CSS override.
Limitation
@importCSS at-rule in the remote stylesheet, those imported stylesheets' CSS rules won't be visible. It will make things more complex if we want to fetch and parse those stylesheets recursively.Screenshots