Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VEN-2083]: Support for syncing of votes #440

Draft
wants to merge 31 commits into
base: develop
Choose a base branch
from
Draft

Conversation

GitGuru7
Copy link
Contributor

@GitGuru7 GitGuru7 commented Jan 31, 2024

Description

Resolves VEN-2083

Related to VenusProtocol/governance-contracts#60

Checklist

  • I have updated the documentation to account for the changes in the code.
  • If I added new functionality, I added tests covering it.
  • If I fixed a bug, I added a test preventing this bug from silently reappearing again.
  • My contribution follows Venus contribution guidelines.

@GitGuru7 GitGuru7 self-assigned this Jan 31, 2024
@chechu chechu changed the title Support for syncing of votes [VEN-2083]: Support for syncing of votes Feb 2, 2024
@chechu chechu added this to the 022 milestone Feb 9, 2024
@GitGuru7 GitGuru7 marked this pull request as ready for review February 14, 2024 11:59
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this XVSVault should be a set of changes on top of the XVSVault modified here: https://github.com/VenusProtocol/venus-protocol/pull/418/files#diff-ba34e5590dd9b2f2198d8098088d1a6fde6d4976728e9eadc4ef4c28201d9947R777

In that new XVSVault we are supporting chains based on timestamps, instead of block numbers

@GitGuru7 GitGuru7 marked this pull request as draft February 29, 2024 11:01
Copy link

github-actions bot commented Mar 7, 2024

Code Coverage

Package Line Rate Branch Rate Health
contracts 100% 100%
contracts.Admin 88% 41%
contracts.Comptroller 100% 90%
contracts.Comptroller.Diamond 95% 59%
contracts.Comptroller.Diamond.facets 75% 65%
contracts.Comptroller.Diamond.interfaces 100% 100%
contracts.DelegateBorrowers 100% 89%
contracts.Governance 33% 20%
contracts.InterestRateModels 47% 67%
contracts.Lens 44% 37%
contracts.Liquidator 83% 60%
contracts.Oracle 100% 100%
contracts.PegStability 88% 84%
contracts.Swap 90% 58%
contracts.Swap.interfaces 100% 100%
contracts.Swap.lib 81% 55%
contracts.Tokens 100% 100%
contracts.Tokens.Prime 96% 72%
contracts.Tokens.Prime.Interfaces 100% 100%
contracts.Tokens.Prime.libs 90% 76%
contracts.Tokens.VAI 71% 46%
contracts.Tokens.VRT 20% 9%
contracts.Tokens.VTokens 68% 50%
contracts.Tokens.XVS 19% 8%
contracts.Utils 50% 30%
contracts.VAIVault 50% 45%
contracts.VRTVault 49% 36%
contracts.XVSVault 76% 58%
contracts.XVSVault.VoteSyncBridgeUtils 73% 53%
contracts.XVSVault.VoteSyncBridgeUtils.interfaces 100% 100%
contracts.lib 75% 25%
Summary 70% (3550 / 5042) 50% (1323 / 2626)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants