Counter cache dont need to be concurrent (#1178)

VerifyTests · Apr 4, 2024 · d10b73a · d10b73a
1 parent 2334ecc
commit d10b73a
Show file tree

Hide file tree

Showing 7 changed files with 17 additions and 6 deletions.
diff --git a/src/Directory.Build.props b/src/Directory.Build.props
@@ -2,7 +2,7 @@
 <Project>
   <PropertyGroup>
     <NoWarn>CS1591;CS0649;xUnit1026;xUnit1013;CS1573;VerifyTestsProjectDir;VerifySetParameters</NoWarn>
-    <Version>23.7.0</Version>
+    <Version>23.7.1</Version>
     <ImplicitUsings>enable</ImplicitUsings>
     <LangVersion>preview</LangVersion>
     <AssemblyVersion>1.0.0</AssemblyVersion>

diff --git a/src/Verify/Counter_Date.cs b/src/Verify/Counter_Date.cs
@@ -3,7 +3,7 @@ namespace VerifyTests;
 
 public partial class Counter
 {
-    ConcurrentDictionary<Date, (int intValue, string stringValue)> dateCache = [];
+    Dictionary<Date, (int intValue, string stringValue)> dateCache = [];
     static Dictionary<Date, string> globalNamedDates = [];
     int currentDate;
 

diff --git a/src/Verify/Counter_DateTime.cs b/src/Verify/Counter_DateTime.cs
@@ -2,7 +2,7 @@
 
 public partial class Counter
 {
-    ConcurrentDictionary<DateTime, (int intValue, string stringValue)> dateTimeCache = new(new DateTimeComparer());
+    Dictionary<DateTime, (int intValue, string stringValue)> dateTimeCache = new(new DateTimeComparer());
     static Dictionary<DateTime, string> globalNamedDateTimes = [];
 
     class DateTimeComparer : IEqualityComparer<DateTime>

diff --git a/src/Verify/Counter_DateTimeOffset.cs b/src/Verify/Counter_DateTimeOffset.cs
@@ -2,7 +2,7 @@
 
 public partial class Counter
 {
-    ConcurrentDictionary<DateTimeOffset, (int intValue, string stringValue)> dateTimeOffsetCache = new(new DateTimeOffsetComparer());
+    Dictionary<DateTimeOffset, (int intValue, string stringValue)> dateTimeOffsetCache = new(new DateTimeOffsetComparer());
     static Dictionary<DateTimeOffset, string> globalNamedDateTimeOffsets = [];
 
     class DateTimeOffsetComparer :

diff --git a/src/Verify/Counter_Guid.cs b/src/Verify/Counter_Guid.cs
@@ -2,7 +2,7 @@
 
 public partial class Counter
 {
-    ConcurrentDictionary<Guid, (int intValue, string stringValue)> guidCache = [];
+    Dictionary<Guid, (int intValue, string stringValue)> guidCache = [];
     static Dictionary<Guid, string> globalNamedGuids = [];
     int currentGuid;
 

diff --git a/src/Verify/Counter_Time.cs b/src/Verify/Counter_Time.cs
@@ -3,7 +3,7 @@ namespace VerifyTests;
 
 public partial class Counter
 {
-    ConcurrentDictionary<Time, (int intValue, string stringValue)> timeCache = [];
+    Dictionary<Time, (int intValue, string stringValue)> timeCache = [];
     static Dictionary<Time, string> globalNamedTimes = [];
     int currentTime;
 

diff --git a/src/Verify/Extensions.cs b/src/Verify/Extensions.cs
@@ -177,6 +177,17 @@ public static void RemoveEmptyLines(this StringBuilder builder)
     public static string Remove(this string value, string toRemove) =>
         value.Replace(toRemove, "");
 
+    public static TValue GetOrAdd<TKey, TValue>(this Dictionary<TKey, TValue> dictionary, TKey key, Func<TKey, TValue> factory)
+        where TKey : notnull
+    {
+        if (dictionary.TryGetValue(key, out var value))
+        {
+            return value;
+        }
+
+        return dictionary[key] = factory(key);
+    }
+
     public static void ReplaceIfLonger(this StringBuilder builder, string oldValue, string newValue)
     {
         if (builder.Length < oldValue.Length)