relax WriteMember type constraint

VerifyTests · Jul 2, 2024 · ee5c684 · ee5c684
1 parent 125d23f
commit ee5c684
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 11 deletions.
diff --git a/src/Directory.Build.props b/src/Directory.Build.props
@@ -2,7 +2,7 @@
 <Project>
   <PropertyGroup>
     <NoWarn>CS1591;CS0649;xUnit1026;xUnit1013;CS1573;VerifyTestsProjectDir;VerifySetParameters;PolyFillTargetsForNuget</NoWarn>
-    <Version>25.1.0</Version>
+    <Version>25.1.1</Version>
     <ImplicitUsings>enable</ImplicitUsings>
     <LangVersion>preview</LangVersion>
     <AssemblyVersion>1.0.0</AssemblyVersion>

diff --git a/src/StrictJsonTests/SerializationTests.WithConverterIgnoreDefault.verified.json b/src/StrictJsonTests/SerializationTests.WithConverterIgnoreDefault.verified.json
@@ -1,6 +1,7 @@
 {
   "withDefault": {},
   "withNonDefault": {
-    "Name": "Value"
+    "Name": "Value",
+    "DateTimeKind": "Local"
   }
 }
diff --git a/src/Verify.Tests/Serialization/SerializationTests.WithConverterIgnoreDefault.verified.txt b/src/Verify.Tests/Serialization/SerializationTests.WithConverterIgnoreDefault.verified.txt
@@ -1,6 +1,7 @@
 {
   withDefault: {},
   withNonDefault: {
-    Name: Value
+    Name: Value,
+    DateTimeKind: Local
   }
 }
diff --git a/src/Verify.Tests/Serialization/SerializationTests.cs b/src/Verify.Tests/Serialization/SerializationTests.cs
@@ -3756,27 +3756,35 @@ public Task WithConverterIgnoreDefault() =>
         Verify(
                 new
                 {
-                    withDefault = new ConverterTarget
+                    withDefault = new ConverterIgnoreDefaultTarget
                     {
-                        Name = "Ignore"
+                        Name = "Ignore",
+                        DateTimeKind = DateTimeKind.Utc
                     },
-                    withNonDefault = new ConverterTarget
+                    withNonDefault = new ConverterIgnoreDefaultTarget
                     {
-                        Name = "Value"
+                        Name = "Value",
+                        DateTimeKind = DateTimeKind.Local
                     },
                 })
             .AddExtraSettings(_ => _.Converters.Add(new ConverterIgnoreDefault()));
 
     class ConverterIgnoreDefault :
-        WriteOnlyJsonConverter<ConverterTarget>
+        WriteOnlyJsonConverter<ConverterIgnoreDefaultTarget>
     {
-        public override void Write(VerifyJsonWriter writer, ConverterTarget target)
+        public override void Write(VerifyJsonWriter writer, ConverterIgnoreDefaultTarget target)
         {
             writer.WriteStartObject();
             writer.WriteMember(target, target.Name, "Name", "Ignore");
+            writer.WriteMember(target, target.DateTimeKind, "DateTimeKind", DateTimeKind.Utc);
             writer.WriteEnd();
         }
     }
+    class ConverterIgnoreDefaultTarget
+    {
+        public string Name { get; set; } = null!;
+        public DateTimeKind DateTimeKind { get; set; }
+    }
 
     [Fact]
     public Task WithRecursiveConverter() =>

diff --git a/src/Verify/Serialization/VerifyJsonWriter.cs b/src/Verify/Serialization/VerifyJsonWriter.cs
@@ -189,14 +189,13 @@ public override void WriteValue(Guid value)
     /// Writes a property name and value while respecting other custom serialization settings.
     /// </summary>
     public void WriteMember<T>(object target, T? value, string name, T defaultIgnore)
-        where T : IEquatable<T?>
     {
         if (value is null)
         {
             return;
         }
 
-        if (value.Equals(defaultIgnore))
+        if (EqualityComparer<T>.Default.Equals(value, defaultIgnore))
         {
             return;
         }