Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't reference System.IO.Compression package #1220

Merged
merged 1 commit into from
Jun 11, 2024

Conversation

ViktorHofer
Copy link
Contributor

@ViktorHofer ViktorHofer commented Jun 9, 2024

System.IO.Compression is inbox on .NET Framework. The package doesn't need to be referenced and will eventually be marked as deprecated.

image

I also cleaned-up the project files as they were hard to read. I hope that's OK.

@SimonCropp
Copy link
Member

the broken build would imply that it is required

C:\projects\verify\src\Verify.NUnit\Verifier_Archive.cs(12,9): error CS0246: The type or namespace name 'ZipArchive' could not be found (are you missing a using directive or an assembly reference?) [C:\projects\verify\src\Verify.NUnit\Verify.NUnit.csproj::TargetFramework=net472]
C:\projects\verify\src\Verify.NUnit\Verifier_Archive.cs(13,14): error CS0246: The type or namespace name 'ZipArchiveEntry' could not be found (are you missing a using directive or an assembly reference?) [C:\projects\verify\src\Verify.NUnit\Verify.NUnit.csproj::TargetFramework=net472]
C:\projects\verify\src\Verify.NUnit\VerifyBase_Archive.cs(12,9): error CS0246: The type or namespace name 'ZipArchive' could not be found (are you missing a using directive or an assembly reference?) [C:\projects\verify\src\Verify.NUnit\Verify.NUnit.csproj::TargetFramework=net472]
C:\projects\verify\src\Verify.NUnit\VerifyBase_Archive.cs(13,14): error CS0246: The type or namespace name 'ZipArchiveEntry' could not be found (are you missing a using directive or an assembly reference?) 

System.IO.Compression is inbox on .NET Framework. The package doesn't need to be referenced and will eventually be marked as deprecated.
@ViktorHofer
Copy link
Contributor Author

the broken build would imply that it is required

PackageReferences flow transitively to consuming projects while <Reference /> items do not. I had to add the reference item to all the projects that use the Compression API. The package isn't required because System.IO.Compression.dll is part of the .NET Framework installation and just needs to be referenced explicitly.

@ViktorHofer
Copy link
Contributor Author

The PR is now ready :)

@SimonCropp
Copy link
Member

@ViktorHofer thanks

@SimonCropp SimonCropp merged commit 2cec300 into VerifyTests:main Jun 11, 2024
3 checks passed
@SimonCropp SimonCropp added this to the 25.0.2 milestone Jun 11, 2024
@SimonCropp
Copy link
Member

i will deploy this now

@ViktorHofer ViktorHofer deleted the patch-1 branch June 11, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants