Breaking: Respect NUnit class level parameters and drop support for custom TestName #1249
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Who is effected
TestFixture
TestCase.TestName
Changes:
No longer respect
TestFixture.TestName
and `TestCase.TestNameReasons
Respect fixture level parameters and ignore NUnit fixture name convention
Previoulsy fixture level parameters were properly not respected by Verify. Verify would rely on NUnit convention for the fixture name. For example
The NUnit fixture name would be
ClassLevelParams(1)
. While unique enough for the verified file it has several problemsTestFixture
parameters inconsistent withTestCase
parametersparamName=paramValue
Sample
Result
Before
After
Migration
After upgrading, the recommended approach is to treat the old verified files as Orphaned verified files.