Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pingfed regression between 2.25 and 2.26 #494

Closed
gliptak opened this issue Apr 27, 2020 · 2 comments · Fixed by #571
Closed

pingfed regression between 2.25 and 2.26 #494

gliptak opened this issue Apr 27, 2020 · 2 comments · Fixed by #571

Comments

@gliptak
Copy link
Contributor

gliptak commented Apr 27, 2020

Running

saml2aws_2.26.exe list-roles
Using IDP Account default to access Ping https://pf.company.com
To use saved password just hit enter.
? Username user@company.com
? Password ****************

Failed to list roles: error parsing destination url: missing Response element

The above is successful with 2.26

v2.25.0...v2.26.0

The failing lookup seems to be:

https://github.com/Versent/saml2aws/blob/master/saml.go#L90

There is no Destination XML element in the response.

@wolfeidau
Copy link
Contributor

Yeah something is up with this change 1b67c79 I may need to revert it, or enable some sort of flag for it.

@michaelsauter
Copy link

I think I'm also running into this issue using v2.27.1 and Ping. After login, I'm getting:

Failed to assume role, please check whether you are permitted to assume the given role for the AWS service: error parsing destination url: missing Response element

Downgrading to v2.25.0 solved the problem for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants