Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getting destination URL #571

Merged
merged 4 commits into from
Nov 10, 2020
Merged

Conversation

tie624
Copy link
Contributor

@tie624 tie624 commented Oct 16, 2020

The SAML Response does not always contain a Destination attribute. When that's the case, the login process fails because it can't find the endpoint to post to. This fix will grab the endpoint from SubjectConfirmationData Recipient when the Destination attribute is not present.

Fixes #523
Fixes #494

@wolfeidau wolfeidau merged commit 407a80d into Versent:master Nov 10, 2020
@gliptak
Copy link
Contributor

gliptak commented Nov 10, 2020

@tie624 @wolfeidau thank you

I validated HEAD against #494

When there might be a release including this fix?

@tie624 tie624 deleted the fix_get_destination_url branch November 10, 2020 20:56
@rhyas
Copy link

rhyas commented Jan 28, 2021

Would be great to see this in a release. Any timeline for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants