add another regex for finding state tokens #1064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## master #1064 +/- ##
==========================================
+ Coverage 36.23% 36.29% +0.05%
==========================================
Files 53 53
Lines 7934 7941 +7
==========================================
+ Hits 2875 2882 +7
Misses 4686 4686
Partials 373 373
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
woohoo thank goodness for this PR, i could only auth in once before getting this error and getting stuck. but i built latest locally and now it's working like a charm, i can |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been having a weird intermittent issue, where trying to log in would sometimes fail with an opaque message:
After a bunch of digging, I discovered that sometimes Okta will request "extra verification" in the form of another 2fa request. Not a big deal, but for whatever reason that page doesn't store the state token as a single variable. Instead, it's burried deep in a blob of almost-JSON.
This change lets us dig up state tokens from those pages as well, which mostly fixes the "cannot find state token" message