-
Notifications
You must be signed in to change notification settings - Fork 562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add okta email mfa support #1281
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1281 +/- ##
==========================================
+ Coverage 42.08% 42.23% +0.15%
==========================================
Files 54 54
Lines 6442 6442
==========================================
+ Hits 2711 2721 +10
+ Misses 3288 3274 -14
- Partials 443 447 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@tmesgong the linter is failing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tmesgong Do you mind adding some tests to this?
@mapkon I don't know how to test. It works for me. I follow the okta sms mfa code, but it doesn't have test. If there's similar test I can follow, I'd like add this later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, you should look at how the okta_test.go
is designed and add a test to exercise your case for the code. I would concentrate on using the test to document the scenarios and state needed for EmailMfa
to function properly.
No description provided.