Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: credential-process flag remove logs [#1293] #1317

Merged
merged 2 commits into from
Jul 21, 2024

Conversation

tinaboyce
Copy link
Contributor

A change made between v2.36.15 to v2.36.16 (current version at time of writing) had introduced an unwanted side-effect of not showing MFA phone numbers when using the --credential-process flag as it also implicitly applies --quiet.

The line in question that was introduced by a commit that made it into v2.36.16 is

if *quiet || (command == cmdLogin.FullCommand() && loginFlags.CredentialProcess) {

Looking at the PR 08035b9#diff-700f078cb6e14d20af7c09e73a1507604a85cfb66d6c54db727f45dc21a13d2a, I do not see any potential side-effects in removing the additional conditions in the "quiet" condition statement to "quiet" the logs.

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.19%. Comparing base (99d6fe4) to head (2afa50b).
Report is 47 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1317   +/-   ##
=======================================
  Coverage   42.19%   42.19%           
=======================================
  Files          54       54           
  Lines        6456     6456           
=======================================
  Hits         2724     2724           
  Misses       3283     3283           
  Partials      449      449           
Flag Coverage Δ
unittests 42.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mapkon mapkon merged commit 8d9068b into Versent:master Jul 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants