fix: credential-process flag remove logs [#1293] #1317
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change made between v2.36.15 to v2.36.16 (current version at time of writing) had introduced an unwanted side-effect of not showing MFA phone numbers when using the
--credential-process
flag as it also implicitly applies--quiet
.The line in question that was introduced by a commit that made it into v2.36.16 is
saml2aws/cmd/saml2aws/main.go
Line 172 in 08035b9
Looking at the PR 08035b9#diff-700f078cb6e14d20af7c09e73a1507604a85cfb66d6c54db727f45dc21a13d2a, I do not see any potential side-effects in removing the additional conditions in the "quiet" condition statement to "quiet" the logs.