Increase waiting sleep for Okta Push to 3 seconds #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paskal
changed the title
|
Previously users will get their verification acknowledged by the saml2aws almost immediately and will get their credentials saved after that. After this PR will be merged, the user will have to wait up to three seconds to get the credentials after they push "Yes, it's me" button in the Okta app. As a side note, this is similar to how okta.com web interface itself works for me: after I push the button in the app, I need to wait a few seconds before browser will recognize it and move to the next screen. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In line with
IdentifierDuoMfa:saml2aws/pkg/provider/okta/okta.go
Line 562 in e602111
I've stumbled upon a problem (#429) where Okta Push MFA getting an error after 8 successful calls to API, which is with current timeouts is 800ms. With this change in place, I'll still get an error after 8 successful calls, but it will give me 24 seconds to push "Yes, it's me" button on my phone in the Okta app instead of current ~1 second.
Details of the problem are in the linked issue.