feat(storage) Keychain storage for password. #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
wolfeidau
commented
Jul 27, 2017
wolfeidau
commented
- Refactor all login related flags.
- Added role command line option
wolfeidau
force-pushed
the
feat_osxkeychain_storage
branch
from
861a4e0
to
e92ed80
Compare
|
LGTM but maybe you have a look at how I implemented the role switch and see if you can take some ideas. Especially, the role selection in the login method. |
wolfeidau
force-pushed
the
feat_osxkeychain_storage
branch
from
e92ed80
to
c651b70
Compare
wolfeidau
force-pushed
the
feat_osxkeychain_storage
branch
from
c651b70
to
9698e41
Compare
|
@hoegertn Thanks a lot you highlighted a case I had missed and proposed a better name for the flag. |
|
👍 looks good. You can reject my PR then. |
|
Do you plan to release a new version? I have customers waiting for the role and TLS fix. |
|
I have built a release and published it, going to do a bit more testing across all providers tomorrow (Australian time) then update the homebrew tap. Any help testing would be appreciated :) Cheers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.