Issue 527: Duo MFA: pass new SID to subsequent API call to DuoSecurity (with backward compatibility) #532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ror.Wrap, otherwise wrapping nil return nil error
|
Hi @wolfeidau - Please review this PR when you get a chance and let me know what you think. |
…s://github.com/himanshu-neema/saml0aws into user/himanshu/duo-security-api-behavior-update
himanshu-neema
changed the title
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue: #527
Fix for Duo Security API change:
POST /frame/status(duoSubmitURLin code )POST /frame/status/<TxID>(duoResultURLin code )Bug fixes (this was causing infinite loop for Duo Push MFA failures) :
verifyMfareturnsnilerror when in fact it should return an error:error.Wrap( )replaced witherror.New( ): because wrappingnilerrreturnsnilUpdate 18th Aug 2020
We noticed API reverted back: hence made the change backward compatible in 6200cf3