Resolve unable to locate IDP oidc form submit URL error due to response body reuse #539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've confirmed this is broken for me with version 2.27.0 but with this PR applied to master it works same as 2.26.1 did. |
|
Confirming, it's working with 2.26.1 and not 2.27.0, the last version, |
|
Any updates on getting this merged in and a new version released? Would really like to see this soon, |
pseidel-kcf
deleted the
feature/aad-reset-response-body-for-later-reads
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@wolfeidau I believe #538 was merged prematurely. These changes fix #530 for me.
This change resolves the
error authenticating to IdP: unable to locate IDP oidc form submit URLcaused by multiple reads of a response body if no KMSI response is received. If a KMSI response is detected then the consumed response variable gets replaced by a response with a fresh body and this is not required.As mentioned on the previous PR I'm not a Go expert so I'm not sure if this is the best approach.