gwt-driver-7 Add faster child/descendant Widget locator #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhickman
commented
Feb 15, 2022
src/main/java/com/vertispan/webdriver/gwt/gwtdriver/client/SeleniumExporter.java
Show resolved
Hide resolved
- Added new exported method "getChildren" - Modified the existing descendant methods to stop including root widget
jhickman
force-pushed
the
gwt-driver-7
branch
from
ba3fda8 to
a742d7b
Compare
removed the need to pass the driver in by getting it from the search context. pulled up common methods into base class. Created convenient static methods in the GwtBy
convenience to call the getChildren exported method.
niloc132
approved these changes
Feb 16, 2022
src/main/java/com/vertispan/webdriver/gwt/gwtdriver/by/ByDescendantWidget.java
Show resolved
Hide resolved
| public List<WebElement> findElements(SearchContext context) { | ||
| Require.nonNull("Search Context", context); | ||
| final WebElement contextElem = toWebElement(context); | ||
| ExportedMethods m = ClientMethodsFactory.create(ExportedMethods.class, getDriver(context)); |
There was a problem hiding this comment.
I wonder if we shouldn't ThreadLocal/WeakRef map these instances to avoid re-creating them each call, and make them easy to look up on the current driver instance...
There was a problem hiding this comment.
maybe. future update. I'll add new ticket
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the unit test to utilize uibinder for easier test UI creation
Added 4 new exported methods:
Added a new "By" for the descendants search
Added a base GwtBy class with some helpers.
Modified each By implementation that needs a WebDriver to extract from the SearchContext