-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(flame_behaviors)!: migrate to flame v1.10.0 #46
Merged
wolfenrain
merged 5 commits into
main
from
feat!(flame_behaviors)-migrate-to-flame-v1.8.0
Oct 18, 2023
Merged
feat(flame_behaviors)!: migrate to flame v1.10.0 #46
wolfenrain
merged 5 commits into
main
from
feat!(flame_behaviors)-migrate-to-flame-v1.8.0
Oct 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfenrain
requested review from
renancaraujo,
erickzanardo and
felangel
as code owners
June 14, 2023 13:01
erickzanardo
previously approved these changes
Sep 13, 2023
wolfenrain
changed the title
feat(flame_behaviors)!: migrate to flame v1.8.0
feat(flame_behaviors)!: migrate to flame v1.10.0
Oct 13, 2023
luanpotter
reviewed
Oct 13, 2023
luanpotter
approved these changes
Oct 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Can't say I agree with the if
style changes but that is just personal preference :P
That wasn't supposed to happen, so I reverted them! |
7 tasks
erickzanardo
approved these changes
Oct 16, 2023
renancaraujo
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated to flame v1.10.0
Closes #29
Type of Change