Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove avoid_null_checks_in_equality_operators #124

Merged
merged 4 commits into from
Nov 25, 2024
Merged

feat: remove avoid_null_checks_in_equality_operators #124

merged 4 commits into from
Nov 25, 2024
+14 −7

Conversation

wolfenrain
Copy link
Member

Status

READY

Description

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@wolfenrain wolfenrain marked this pull request as ready for review November 11, 2024 11:50
@wolfenrain wolfenrain requested a review from a team as a code owner November 11, 2024 11:50
@wolfenrain wolfenrain mentioned this pull request Nov 11, 2024
Closed
11 tasks
alestiago
alestiago reviewed Nov 11, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@tomarra tomarra added the p1 High-priority issues at the top of the work list label Nov 19, 2024
@tomarra
Copy link
Contributor

tomarra commented Nov 25, 2024

Information on this being deprecated https://dart.dev/tools/linter-rules/avoid_null_checks_in_equality_operators

Need to confirm that the non_nullable_equals_parameter is either on by default or we need another ticket to enable this.

@tomarra tomarra merged commit 00f898a into main Nov 25, 2024
4 checks passed
@tomarra tomarra deleted the feat-remove-avoid_null_checks_in_equality_operators branch November 25, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alestiago alestiago alestiago left review comments

@tomarra tomarra tomarra approved these changes

Assignees
No one assigned
Labels
p1 High-priority issues at the top of the work list
Projects
VGV Open Source 🦄 🧙🌟
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wolfenrain @tomarra @alestiago