feat(test): imply --coverage when --min-coverage is supplied (#367)

VeryGoodOpenSource · May 5, 2022 · 666b513 · 666b513
1 parent a828288
commit 666b513
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/lib/src/commands/test/test.dart b/lib/src/commands/test/test.dart
@@ -137,7 +137,7 @@ This command should be run from the root of your Flutter project.''',
  progress: _logger.progress,
  stdout: _logger.write,
  stderr: _logger.err,
- collectCoverage: collectCoverage,
+ collectCoverage: collectCoverage || minCoverage != null,
  minCoverage: minCoverage,
  excludeFromCoverage: excludeFromCoverage,
  randomSeed: randomSeed,

diff --git a/test/src/commands/test/test_test.dart b/test/src/commands/test/test_test.dart
@@ -304,6 +304,24 @@ void main() {
  ).called(1);
  });
 
+ test('enables coverage collection when --min-coverage is supplied',
+ () async {
+ when<dynamic>(() => argResults['min-coverage']).thenReturn('0');
+ final result = await testCommand.run();
+ expect(result, equals(ExitCode.success.code));
+ verify(
+ () => flutterTest(
+ optimizePerformance: true,
+ collectCoverage: true,
+ arguments: defaultArguments,
+ minCoverage: 0,
+ progress: logger.progress,
+ stdout: logger.write,
+ stderr: logger.err,
+ ),
+ ).called(1);
+ });
+
  test('fails when coverage not met', () async {
  when<dynamic>(() => argResults['coverage']).thenReturn(true);
  when<dynamic>(() => argResults['min-coverage']).thenReturn('100');