feat: improve very good create output (#131)

VeryGoodOpenSource · May 25, 2021 · fc62b08 · fc62b08
1 parent bcff075
commit fc62b08
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 15 deletions.
diff --git a/lib/src/commands/create.dart b/lib/src/commands/create.dart
@@ -73,7 +73,7 @@ class CreateCommand extends Command<int> {
  DirectoryGeneratorTarget(outputDirectory, _logger),
  vars: {'project_name': projectName},
  );
- generateDone('Bootstrapping complete');
+ generateDone('Generated $fileCount file(s)');
 
  final isFlutterInstalled = await Flutter.installed();
  if (isFlutterInstalled) {
@@ -84,7 +84,7 @@ class CreateCommand extends Command<int> {
  installDependenciesDone();
  }
 
- _logSummary(fileCount);
+ _logSummary();
 
  unawaited(_analytics.sendEvent(
  'create',
@@ -96,13 +96,8 @@ class CreateCommand extends Command<int> {
  return ExitCode.success.code;
  }
 
- void _logSummary(int fileCount) {
+ void _logSummary() {
  _logger
- ..info(
- '${lightGreen.wrap('✓')} '
- 'Generated $fileCount file(s):',
- )
- ..flush(_logger.success)
  ..info('\n')
  ..alert('Created a Very Good App! 🦄')
  ..info('\n')

diff --git a/test/src/commands/create_test.dart b/test/src/commands/create_test.dart
@@ -1,5 +1,4 @@
 import 'package:args/args.dart';
-import 'package:io/ansi.dart';
 import 'package:io/io.dart';
 import 'package:mason/mason.dart';
 import 'package:mocktail/mocktail.dart';
@@ -21,6 +20,7 @@ class FakeDirectoryGeneratorTarget extends Fake
 
 void main() {
  group('Create', () {
+ late List<String> progressLogs;
  late Analytics analytics;
  late Logger logger;
  late VeryGoodCommandRunner commandRunner;
@@ -30,6 +30,7 @@ void main() {
  });
 
  setUp(() {
+ progressLogs = <String>[];
  analytics = MockAnalytics();
  when(() => analytics.firstRun).thenReturn(false);
  when(() => analytics.enabled).thenReturn(false);
@@ -41,7 +42,11 @@ void main() {
  ).thenAnswer((_) => Future.value());
 
  logger = MockLogger();
- when(() => logger.progress(any())).thenReturn(([_]) {});
+ when(() => logger.progress(any())).thenReturn(
+ ([_]) {
+ if (_ != null) progressLogs.add(_);
+ },
+ );
  commandRunner = VeryGoodCommandRunner(
  analytics: analytics,
  logger: logger,
@@ -107,12 +112,10 @@ void main() {
  final result = await command.run();
  expect(result, equals(ExitCode.success.code));
  verify(() => logger.progress('Bootstrapping')).called(1);
+ expect(progressLogs, equals(['Generated 62 file(s)']));
  verify(
- () => logger.info(
- '${lightGreen.wrap('✓')} '
- 'Generated 62 file(s):',
- ),
- );
+ () => logger.progress('Running "flutter packages get" in .tmp'),
+ ).called(1);
  verify(() => logger.alert('Created a Very Good App! 🦄')).called(1);
  verify(
  () => generator.generate(