Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Update bundle with newest gradle plugin version #118

Closed
mrverdant13 opened this issue Apr 8, 2021 · 3 comments · Fixed by VeryGoodOpenSource/very_good_core#32 or #129
Closed
Assignees
Labels
bug Something isn't working as expected

Comments

@mrverdant13
Copy link

Description
The gradle version might be pumped to meet the current base Flutter project setup.

Steps To Reproduce

  1. Go to your_project\android\build.gradle
  2. See buildscript.dependencies and you will find that the current plugin version is 3.6.3.

Expected Behavior
At the moment, the flutter create command already sets the plugin version to 4.1.0.
No huge impact on builds but just for the sake of consistency.

Screenshots
image

Additional Context
very_good version: 0.1.7

Flutter 2.0.3 • channel stable • https://github.com/flutter/flutter.git
Framework • revision 4d7946a68d (3 weeks ago) • 2021-03-18 17:24:33 -0700
Engine • revision 3459eb2436
Tools • Dart 2.12.2

@mrverdant13 mrverdant13 added the bug Something isn't working as expected label Apr 8, 2021
@felangel felangel self-assigned this Apr 8, 2021
@felangel
Copy link
Contributor

felangel commented Apr 8, 2021

Hi @mrverdant13 👋
Thanks for opening an issue!

The gradle version was downgraded due to #104. Can you confirm that you're not experiencing any build issues on Android? I'll double check as well as soon as I can, thanks! 🙏

@mrverdant13
Copy link
Author

mrverdant13 commented Apr 10, 2021

Hello, @felangel

I just tested the base project on some Android devices with no bugs at all.

Besides that, the only potential issue I found is related to the Android queries element as described here.

In short, there is a minimum plugin version regarding compatibility:

image

The current plugin version is 3.6.3. This might be upgraded to 3.6.4 to meet this requirement.
However, since I could test the base app with 4.0.1 version without issues, I think it is pretty safe bet.

mrverdant13 added a commit to mrverdant13/very_good_cli that referenced this issue Apr 10, 2021
mrverdant13 added a commit to mrverdant13/very_good_cli that referenced this issue Apr 10, 2021
@felangel
Copy link
Contributor

Working on this however I think we need to wait until the fix has made it's way into stable (flutter/flutter#82262)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected
Projects
None yet
2 participants