Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: flutter_plugin template generates all platforms no matter the platform flag used #424

Closed
wolfenrain opened this issue Jun 8, 2022 · 2 comments · Fixed by #462
Closed
Assignees
Labels
bug Something isn't working as expected

Comments

@wolfenrain
Copy link
Member

Description

As a developer I can create a flutter_plugin template using the CLI and pass which platforms I dont want using the --<platform_name> false option. This works as expected but the example generated for the plugin will still contain all platforms.

Steps To Reproduce

  1. Run very_good create my_plugin -t flutter_plugin --ios false
  2. Check the my_plugin/my_plugin/example directory, it will contain an iOS dir.

Expected Behavior

That the generated example only has the platforms that I require for my plugin.

@wolfenrain wolfenrain added the bug Something isn't working as expected label Jun 8, 2022
@wolfenrain wolfenrain self-assigned this Jun 21, 2022
@dewinjm
Copy link
Contributor

dewinjm commented Jul 7, 2022

The same goes with .github/workflows/ files.

When run for example very_good create abc_plugin -t flutter_plugin --web false --windows false --macos false --linux false

The workflows directory contains all platforms template and keep my_plugin files even though the plugin name is abc_plugin:

screenshot

I see this file flutter_plugin_bundle.dart has the workflows static path. "my_plugin.yaml, my_plugin_android.yaml, ..."

@wolfenrain
Copy link
Member Author

Change the template project to reflect the above mentioned changes: VeryGoodOpenSource/very_good_flutter_plugin#41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working as expected
Projects
None yet
2 participants