fix(flutter_plugin): remove static workflows #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution! This change should be applied to the generator script on the very_good_flutter_plugin so that we can then update the bundles based on that. I already added changed this for the fix for #424 (VeryGoodOpenSource/very_good_flutter_plugin#41) but to ensure that we don't lose your contribution we can merge this if you like. Can you resolve the conflicts on your branch? Once again thanks for this PR! |
# Conflicts: #lib/src/commands/create/templates/flutter_plugin/flutter_plugin_bundle.dart
wolfenrain
approved these changes
Jul 13, 2022
renancaraujo
approved these changes
Jul 13, 2022
felangel
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove static workflows paths
my_plugin.yaml, my_plugin_android.yaml, ...Because when run for example:
very_good create abc_plugin -t flutter_pluginkeepmy_plugin...files even though the plugin name is abc_plugin.For further details, see my comment here: #424 (comment)
Type of Change