-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: very_good test doesn't like [ in file names #648
Labels
Comments
Given that this is a P1 (highest priority), anyone taking this must be ready to respond to feedback quickly to make sure it gets pushed. |
alestiago
added a commit
to alestiago/issues
that referenced
this issue
Feb 20, 2023
alestiago
added
waiting for response
Waiting for follow up
and removed
waiting for response
Waiting for follow up
labels
Feb 20, 2023
Reproduced issue with minimal sample code under version Error logvery_good test
Running "flutter test" in /Users/alestiago/Developer/workspace/oss/issues/very_good_cli/648...
✓ Optimizing tests (97ms)
test/.test_runner.dart:9:41: Error: Expected ';' after this.
import 'widget[1]_special_test.dart' as widget[1]_special_test_dart;
^^^^^^
test/.test_runner.dart:9:47: Error: Expected a declaration, but got '['.
import 'widget[1]_special_test.dart' as widget[1]_special_test_dart;
^
test/.test_runner.dart:9:48: Error: Expected a declaration, but got '1'.
import 'widget[1]_special_test.dart' as widget[1]_special_test_dart;
^
test/.test_runner.dart:9:49: Error: Expected a declaration, but got ']'.
import 'widget[1]_special_test.dart' as widget[1]_special_test_dart;
^
test/.test_runner.dart:9:50: Error: Variables must be declared using the keywords 'const', 'final', 'var' or a type name.
Try adding the name of the type of the variable or the keyword 'var'.
import 'widget[1]_special_test.dart' as widget[1]_special_test_dart;
^^^^^^^^^^^^^^^^^^
test/.test_runner.dart:10:1: Error: Directives must appear before any declarations.
Try moving the directive before any declarations.
import 'widget_test.dart' as widget_test_dart;
^^^^^^
test/.test_runner.dart:14:45: Error: A prefix can't be used as an expression.
group('widget[1]_special_test_dart', () { widget[1]_special_test_dart.main(); });
^^^^^^
test/.test_runner.dart:14:53: Error: Expected ';' after this.
group('widget[1]_special_test_dart', () { widget[1]_special_test_dart.main(); });
^
Failed to load "/Users/alestiago/Developer/workspace/oss/issues/very_good_cli/648/test/.test_runner.dart": Compilation failed for testPath=/Users/alestiago/Developer/workspace/oss/issues/very_good_cli/648/test/.test_runner.dart
loading /Users/alestiago/Developer/workspace/oss/issues/very_good_cli/648/test/.test_runner.dart /Users/alestiago/Developer/workspace/oss/issues/very_good_cli/648/test/.test_runner.dart (FAILED)
00:00 -1: Some tests failed.
Failing Tests:
- [ERROR] ...=/Users/alestiago/Developer/workspace/oss/issues/very_good_cli/648/test/.test_runner.dart |
@KyleFin the issue seems to be within the optimisation process. In the meantime you can use: very_good test --no-optimization |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
very_good test fails when files have [] in their filenames (as seen in Dart Frog dynamic route files).
Steps To Reproduce
Expected Behavior
A clear and concise description of what you expected to happen.
Screenshots
Additional Context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: