Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test optimizer to import files as valid dart names #658

Merged
merged 18 commits into from
Feb 22, 2023

Conversation

alestiago
Copy link
Contributor

@alestiago alestiago commented Feb 20, 2023

Description

Instead of importing files as a snaked case name of the relative path, the test files are assigned an alphabetic identifier.

Before:

import 'something[1]_test.dart' as something[1]_test; // Invalid dart identifier

After:

import 'something[1]_test.dart' as _a;

Resolves #648

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@alestiago alestiago merged commit 61345cc into main Feb 22, 2023
@alestiago alestiago deleted the fix/square-brackets-not-allowed-as-imports branch February 22, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: very_good test doesn't like [ in file names
3 participants