-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(#377): list failing tests #397
Conversation
lib/src/cli/flutter_cli.dart
Outdated
return previousValue; | ||
}, | ||
); | ||
stdout(lines.toString()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome!
Should we log them via stderr
? Also what about if test descriptions are really long? Do we want to handle truncating or just let the names wrap?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to output the suite paths. I see no problem on wrapping them. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also changed to output via stderr
. I was going to wrap everything on red but since the Logger.error
does that for us, it was not necessary.
1df0121
to
149c1c2
Compare
Changed it to have an output including line and column, as well as the path of to the suite. Without optimization, the output is:
With optimization, the output is:
|
bef33d7
to
f442f00
Compare
Update: Changed to retrieve the test location from the stack trace. In this way, the right path is recovered regardless of the optimization being true of false .
|
f442f00
to
1bf7c98
Compare
1bf7c98
to
ed280ec
Compare
7733842
to
167ce34
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💯
Description
Adds a listing of failing tests after a test run as proposed on #377
Type of Change