Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(373): check if there is a test directory before run flutter test #404

Merged
merged 3 commits into from
May 20, 2022
Merged

fix(373): check if there is a test directory before run flutter test #404

merged 3 commits into from
May 20, 2022

Conversation

eliasreis54
Copy link
Contributor

Description

Check if there is a test directory before calling the flutter test.

Proposal to fix the #373

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@eliasreis54 eliasreis54 self-assigned this May 20, 2022
eliasreis54 and others added 2 commits May 20, 2022 12:46
@eliasreis54 @felangel
Apply suggestions from code review
a4a6b1d 
Co-authored-by: Felix Angelov <felangelov@gmail.com>
@eliasreis54
Merge branch 'main' into fix/373
c688399
felangel
felangel approved these changes May 20, 2022
View reviewed changes
Copy link
Contributor

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@felangel felangel merged commit 3ece759 into VeryGoodOpenSource:main May 20, 2022
@felangel felangel mentioned this pull request May 20, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felangel felangel felangel approved these changes

@jorgecoca jorgecoca Awaiting requested review from jorgecoca

Assignees

@eliasreis54 eliasreis54

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eliasreis54 @felangel