Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(test): support --tags option #421

Merged
merged 3 commits into from
Jun 15, 2022
Merged

feat(test): support --tags option #421

merged 3 commits into from
Jun 15, 2022

Conversation

agacemi
Copy link
Contributor

@agacemi agacemi commented Jun 3, 2022

Description

This PR add the support of tags option in very_good command-line as described in #420 .

Type of Change

  • [ x] ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@felangel felangel added the feature A new feature or request label Jun 6, 2022
@felangel felangel linked an issue Jun 6, 2022 that may be closed by this pull request
feat(test): support "tags" option #420
Closed
@felangel felangel changed the title Support tags option in command-line feat(test): support --tags option Jun 7, 2022
felangel
felangel approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@felangel felangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉
Thanks so much for the contribution! 💙

@felangel felangel merged commit f84d488 into VeryGoodOpenSource:main Jun 15, 2022
@felangel felangel mentioned this pull request Jun 15, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felangel felangel felangel approved these changes

@jorgecoca jorgecoca Awaiting requested review from jorgecoca

@erickzanardo erickzanardo Awaiting requested review from erickzanardo

@renancaraujo renancaraujo Awaiting requested review from renancaraujo

@wolfenrain wolfenrain Awaiting requested review from wolfenrain

Assignees

@agacemi agacemi

Labels
feature A new feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(test): support "tags" option
2 participants
@agacemi @felangel