-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type: add helpers for managing typeof and attributed types #757
Conversation
Wouldn't something more like Maybe a |
Is the idea that each function that currently recurses on typeof/attributed types, should instead call canonicalize/base on its argument first? I think that would also work and yeah probably simpler. |
Something like that yes. It would also work well if in the future |
This branch has a fairly heavy performance hit (~5% for large files), and even with just Type.base replacing |
The idea behind this is to prepare for #733 by making typeof and attributed types slightly less annoying to deal with, by moving the recursive call logic to a single place (2 actually), which should make it easier to add a new
typedef
specifier which will generally just call into its subtype for most of the Type functions.