Issue a warning on packed record member access #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehaas
reviewed
Nov 10, 2024
src/aro/Diagnostics.zig
Outdated
| @@ -21,6 +21,10 @@ pub const Message = struct { | |||
|
|
|||
| pub const Extra = union { | |||
| str: []const u8, | |||
| record_member: struct { | |||
There was a problem hiding this comment.
This makes the Extra union 32 bytes instead of 16 (on a 64-bit system). We should use something like what is done in errDeprecated or valueChangedStr - write the string to p.strings, dupe it, and then just use the .str Extra field
Co-authored-by: Evan Haas <evan@lagerdata.com>
ehaas
reviewed
Nov 10, 2024
src/aro/Parser.zig
Outdated
| @@ -7226,8 +7241,7 @@ fn unExpr(p: *Parser) Error!Result { | |||
| const lhs_ty = p.nodes.items(.ty)[@intFromEnum(data.member.lhs)]; | |||
| if (lhs_ty.hasAttribute(.@"packed")) { | |||
| const record = lhs_ty.getRecord().?; | |||
| const mapper = p.comp.string_interner.getSlowTypeMapper(); | |||
| const extra = Diagnostics.Message.Extra{ .record_member = .{ .record = mapper.lookup(record.name), .member = mapper.lookup(record.fields[data.member.index].name) } }; | |||
| const extra = Diagnostics.Message.Extra{ .str = try p.packedMemberAccessStr(record.name, record.fields[data.member.index].name) }; | |||
| try p.errExtra(.packed_member_address, orig_tok_i, extra); | |||
There was a problem hiding this comment.
You can use the errStr function here with the string
ehaas
approved these changes
Nov 10, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #788