represent Type as a tagged union #809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vexu
force-pushed
the
rewrite-type
branch
2 times, most recently
from
603ea97 to
9e168a1
Compare
Inspired by the similar changes to the AST (#807) this should finally make Type less painful to use.
This enables parsing function bodies even if the function prototype was invalid.
|
Slowly getting there... #test-integration:
282 passed; 53 failed.
#test-record:
max mem used = 8.49MiB
8270 passed; 657 failed (518 invalid targets).Looks like there will be a nice bonus 0.4 MiB memory usage drop from #817 (comment) |
|
I'll allow some record layout tests to regress to get this merged, those can be fixed later when I recover from this. This will almost definitely also regress untested code paths considering how long it took to get the tested ones working again, probably a good time to do some fuzz testing with this and #807 touching so many parts of the compiler. |
|
Nice work! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by the similar changes to the AST (#807) this should finally make Type less painful to use.
Closes #733