ffmpeg-encoder/dnxhr: Added Avid DNxHR Encoder based on FFmpeg #784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Alright. I changed the mentioned parts and use string-based profile mapping instead of integer-based. |
|
The only thing that is still needed is to create a wiki page for the new encoder and change the URL inside the handler accordingly. |
Xaymar
reviewed
Feb 25, 2022
Xaymar
requested changes
Feb 25, 2022
|
I implemented the requested changes. All files have been run through clang-format. |
Xaymar
approved these changes
Feb 26, 2022
|
Merging into v0.12 once checks finish. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the Pull Request
Added encoder for Avid DNxHR for 8 and 10 bit formats (although OBS doesn't support 10bit - yet).
This is an alternative to the existing ProRes encoder.
Why is this necessary?
The default DNx encoder, that can be used through OBS' integrated FFmpeg output, cannot do proper 4:2:2 chroma as it is missing pixel format conversions from 4:4:4 to 4:2:0. Therefore, you could only record 4:2:0 as 4:2:2, which is not true 4:2:2, or 4:4:4 as 4:4:4 (DNxHR 444 10bit), which is massive in size and often unnecessary.
OBS has no native 4:2:2 option (yet).
Checklist