Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Remove Code Signing with self-signed certificate #873

Merged
merged 1 commit into from
Aug 13, 2022
Merged

ci: Remove Code Signing with self-signed certificate #873

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 2 additions & 22 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,15 +195,6 @@ jobs:
build/temp/autodeps
key: autodeps-${{ matrix.runner }}-${{ matrix.generator }}-${{ matrix.CMAKE_BUILD_TYPE }}-${{ env.CACHE_VERSION }}

- name: "Code Signing (Windows)" # Do not run this on pull requests, ever!
if: (github.event_name != 'pull_request') && startsWith( matrix.runner, 'windows' )
id: codesign
shell: bash
run: |
# Restore the Certificate back into a file.
echo "${{ secrets.CODESIGN_CERT_WIN }}" | base64 --decode > "${{ github.workspace }}/cert.pfx"
echo "::set-output name=cmake_args::-DENABLE_CODESIGN=ON -DCODESIGN_TIMESTAMPS=ON"

- name: "Configure"
shell: bash
env:
Expand All @@ -216,7 +207,6 @@ jobs:
ENABLE_PROFILING=OFF
fi
cmake -H. -B"build/temp" \
${{ steps.codesign.outputs.cmake_args }} \
-DCMAKE_BUILD_TYPE=${{ matrix.CMAKE_BUILD_TYPE }} \
-DCMAKE_INSTALL_PREFIX="build/distrib" \
-DPACKAGE_NAME="streamfx-${{ matrix.PACKAGE_NAME }}" \
Expand Down Expand Up @@ -257,22 +247,12 @@ jobs:
cmake --build "build/temp" --config RelWithDebInfo --target PACKAGE_7Z
cmake --build "build/temp" --config RelWithDebInfo --target PACKAGE_ZIP

- name: "Package: Installer Code Signing (Windows)"
if: (github.event_name != 'pull_request') && startsWith( matrix.runner, 'windows' )
id: codesign_install
shell: bash
run: |
if [[ -f "${{ github.workspace }}/cert.pfx" ]]; then
signtool=$(awk 'match($0, /^;signtool=(.+)$/, ary) {print ary[1]}' "${{ github.workspace }}/build/temp/installer.iss")
echo "::set-output name=iscc_signtool::${signtool}"
fi

- name: "Package: Installer (Windows)"
if: startsWith( matrix.runner, 'windows' )
shell: cmd
run: |
echo '"C:\Program Files (x86)\Inno Setup 6\ISCC.exe" /V10 "/Ssigntool=${{ steps.codesign_install.outputs.iscc_signtool }} $p" ".\build\temp\installer.iss"'
"C:\Program Files (x86)\Inno Setup 6\ISCC.exe" /V10 "/Ssigntool=${{ steps.codesign_install.outputs.iscc_signtool }} $p" ".\build\temp\installer.iss"
echo '"C:\Program Files (x86)\Inno Setup 6\ISCC.exe" /V10 ".\build\temp\installer.iss"'
"C:\Program Files (x86)\Inno Setup 6\ISCC.exe" /V10 ".\build\temp\installer.iss"

- name: "Package: Installer (MacOS)"
if: startsWith( matrix.runner, 'macos' )
Expand Down