Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle 8.3 and other dependency updates. #259

Merged
merged 4 commits into from
Oct 1, 2023
Merged

Gradle 8.3 and other dependency updates. #259

merged 4 commits into from
Oct 1, 2023

Conversation

Kichura
Copy link
Member

@Kichura Kichura commented Oct 1, 2023

Dependencies that will be updated:

Checkout action: v3 -> v4,
Fabric loom: 1.3 -> 1.4,
Yarn: 1.20.2-build.1 -> 1.20.2-build.2,
Fabric API: 0.89.0 -> 0.89.3,
ViaVersion + ViaBackwards: 4.8.0 -> 4.8.1-SNAPSHOT,
Reflect: 1.2.4 -> 1.3.0-SNAPSHOT,
Netty (Codec HTTP): 4.1.96-Final -> 4.1.99-Final,
MixinExtras: 0.2.0-beta.9 -> 0.2.0-rc.5,
Gradle: 8.2.1 -> 8.3.

Classic4J has a newer version (1.2.1) but due to it's internal classes being different, it doesn't work with VFP at this time.
(Testing is required before merging this PR - Also JitPack now automatically picks the correct temurin JDK needed for compiling)

This dependency has failed the CI building test and therefore will be reverted, Also the dependency has changed internal classes and therefore will not work with VFP at this time.
@FlorianMichael
Copy link
Member

You will have to revert some changes:
ViaVersion + ViaBackwards: 4.8.0 -> 4.8.1-SNAPSHOT: Via 4.8.1-SNAPSHOT is currently broken with ViaLegacy.
Netty (Codec HTTP): 4.1.96-Final -> 4.1.99-Final: No, It's only for ViaBedrock and I don't want library mismatch.
Reflect: 1.2.4 -> 1.3.0-SNAPSHOT: Still in development, so no.

I'm gonna update Classic4J by myself.

ViaVersion and Netty updates cause ViaBedrock + ViaLegacy to break and Reflect 1.3.0-SNAPSHOT is marked as not ready.
@Kichura
Copy link
Member Author

Kichura commented Oct 1, 2023

You will have to revert some changes: ViaVersion + ViaBackwards: 4.8.0 -> 4.8.1-SNAPSHOT: Via 4.8.1-SNAPSHOT is currently broken with ViaLegacy. Netty (Codec HTTP): 4.1.96-Final -> 4.1.99-Final: No, It's only for ViaBedrock and I don't want library mismatch. Reflect: 1.2.4 -> 1.3.0-SNAPSHOT: Still in development, so no.

I'm gonna update Classic4J by myself.

reverted.

@FlorianMichael FlorianMichael merged commit 253e0f7 into ViaVersion:main Oct 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants