Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tilt Firstperson Handheld Items <=1.7.x #535

Merged
merged 5 commits into from
Aug 20, 2024

Conversation

lowercasebtw
Copy link
Collaborator

Tilts the firstperson handheld items for 1.7.x and below, which also makes blocking in 1.7 accurate too and many/most/all items too.

Values worked on/modified from 1.7 and converted by mixcesta.

Copy link
Member

@FlorianMichael FlorianMichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since 1.7 is older than 1.8, the new function needs to be below the other one.

Also can you show images comparing before/after so I can see what this tries to fix?

@lowercasebtw
Copy link
Collaborator Author

image

@lowercasebtw
Copy link
Collaborator Author

lowercasebtw commented Aug 20, 2024

this image, is using the changes from this pr in VFP btw, prior it would just look like the 1.8 ones

@lowercasebtw
Copy link
Collaborator Author

lowercasebtw commented Aug 20, 2024

Before & After the PR changes, along with the vanilla equivalents of the visual below

Top are both on Mineman Club (set version to 1.7.10)
image

The difference
image

@FlorianMichael FlorianMichael merged commit 935c1cd into ViaVersion:main Aug 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants